Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Y Yodoo Apps Database
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • crnd-opensource
  • Yodoo Apps Database
  • Merge requests
  • !66

Merged
Created Aug 20, 2026 by Volodymyr Karabanov@vovikDeveloper

[FIX] yodoo_apps_website: use kwargs form of create_children for task specs

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 4

What was broken

generic.task.queue.task.create_children() raised ValidationError: Pass task specs positionally OR the keyword type_code / params_list shorthand, not both. inside _collect_specs. Source-to-task-queue sync in yodoo_apps_website was completely broken — no branch-sync tasks could be created.

Cause

The create_children contract was rewritten around TaskSpec (generic-background-service commit 6ecf3f0). The call site in yodoo_apps_website/services/sync_task_types.py was left on the old mixed form (positional specs + kwargs channel), which the new contract rejects.

What was done

  • Switched the call to the homogeneous kwargs form (type_code=, params_list=, channel=).
  • Added a red-first test that reproduced the failure before the fix, plus a negative control confirming the old positional form still raises.
  • Bumped version 18.0.1.5.5 -> 18.0.1.5.6.

Evidence

  • odoo.tests.result: 0 failed, 0 error(s) of 3 tests
  • flake8 clean
  • pylint 10.00/10
  • review: approved

🤖 Generated with Claude Code

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 18.0-fix-yodoo-apps-website-create-children